Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/
---

(Updated March 21, 2016, 9:24 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary,


Diffs (updated)
-

  docs/app-framework-development-guide.md 
1d8bebde67f69fd414509b8861571137d3569b46 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
  src/python/interface/src/mesos/interface/__init__.py 
232890daa6d222ae1c86906bbc484c8e635c4eb7 

Diff: https://reviews.apache.org/r/45039/diff/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Alexander Rukletsov]

> On March 18, 2016, 8:28 p.m., Joerg Schad wrote:
> > include/mesos/scheduler.hpp, line 220
> > 
> >
> > Can you also update  
> > https://github.com/apache/mesos/blob/master/docs/app-framework-development-guide.md

Thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review124272
---


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> ---
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary,
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
> 
> Diff: https://reviews.apache.org/r/45039/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Alexander Rukletsov]

> On March 18, 2016, 9:58 p.m., Ben Mahler wrote:
> > include/mesos/scheduler.hpp, lines 219-221
> > 
> >
> > This change needs to propagate to the Java and Python side, in addition 
> > to what Joerg mentioned, grepping will show you:
> > 
> > ```
> > $ grep -R "description of Filters" src include
> > src/java/src/org/apache/mesos/SchedulerDriver.java:   * unused 
> > resources (see mesos.proto for a description of Filters).
> > src/java/src/org/apache/mesos/SchedulerDriver.java:   * resources (see 
> > mesos.proto for a description of Filters).
> > src/python/interface/src/mesos/interface/__init__.py:  mesos.proto 
> > for a description of Filters). Available resources are
> > src/python/interface/src/mesos/interface/__init__.py:  unused 
> > resources (see mesos.proto for a description of Filters).
> > include/mesos/scheduler.hpp:  // resources (see mesos.proto for a 
> > description of Filters).
> > include/mesos/scheduler.hpp:  // resources (see mesos.proto for a 
> > description of Filters).
> > ```

Thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review124299
---


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> ---
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary,
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
> 
> Diff: https://reviews.apache.org/r/45039/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review124272
---




include/mesos/scheduler.hpp (line 220)


Can you also update  
https://github.com/apache/mesos/blob/master/docs/app-framework-development-guide.md


- Joerg Schad


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> ---
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary,
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
> 
> Diff: https://reviews.apache.org/r/45039/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review124299
---




include/mesos/scheduler.hpp (lines 219 - 221)


This change needs to propagate to the Java and Python side, in addition to 
what Joerg mentioned, grepping will show you:

```
$ grep -R "description of Filters" src include
src/java/src/org/apache/mesos/SchedulerDriver.java:   * unused resources 
(see mesos.proto for a description of Filters).
src/java/src/org/apache/mesos/SchedulerDriver.java:   * resources (see 
mesos.proto for a description of Filters).
src/python/interface/src/mesos/interface/__init__.py:  mesos.proto for 
a description of Filters). Available resources are
src/python/interface/src/mesos/interface/__init__.py:  unused resources 
(see mesos.proto for a description of Filters).
include/mesos/scheduler.hpp:  // resources (see mesos.proto for a 
description of Filters).
include/mesos/scheduler.hpp:  // resources (see mesos.proto for a 
description of Filters).
```


- Ben Mahler


On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> ---
> 
> (Updated March 18, 2016, 5:13 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary,
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
> 
> Diff: https://reviews.apache.org/r/45039/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>