----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45203/#review128021 -----------------------------------------------------------
This test looks fine, but what about testing the positive case? In a previous version of another patch, you replaced `checkWithRolesEndpoint` with a version that used GET on /weights. Can you revive that so we can make sure we're testing that a successful request returns the expected response? src/tests/dynamic_weights_tests.cpp (line 520) <https://reviews.apache.org/r/45203/#comment191419> s/response1/response/ - Adam B On March 23, 2016, 1:53 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45203/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 1:53 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4316 > https://issues.apache.org/jira/browse/MESOS-4316 > > > Repository: mesos > > > Description > ------- > > Add authentication test for /weights GET request. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 > > Diff: https://reviews.apache.org/r/45203/diff/ > > > Testing > ------- > > make && make check. > > $ ./src/mesos-tests > --gtest_filter=DynamicWeightsTest.UnauthenticatedQueryWeightRequest > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from DynamicWeightsTest > [ RUN ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest > [ OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (81 ms) > [----------] 1 test from DynamicWeightsTest (81 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (91 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
