Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Joerg Schad]

> On March 28, 2016, 5 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 46
> > 
> >
> > When did we start making 'enum' names be in caps? There is an enum 7 
> > lines above that is not in all caps.

Thx! Fixed that with this review: https://reviews.apache.org/r/45400/


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/#review125676
---


On March 28, 2016, 4:52 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45232/
> ---
> 
> (Updated March 28, 2016, 4:52 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5049
> https://issues.apache.org/jira/browse/MESOS-5049
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some newly created processes such as perf should be killed in case the
> parent dies. Currently this is achieved by forking a new process from the
> child process which serves as a 'watchdog' and kill the child if the parent
> dies. This review introduces this as a general behavior into subprocess
> (and hence removes the need for the custom setup function).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/subprocess.cpp 
> b99bad04f7251169df3bfcec5dee459977440997 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 09e46eb1ce10a6c38cc364077f0b5952579d46e7 
> 
> Diff: https://reviews.apache.org/r/45232/diff/
> 
> 
> Testing
> ---
> 
> Tested complete chain (see https://reviews.apache.org/r/45236/).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/#review125676
---




3rdparty/libprocess/include/process/subprocess.hpp (line 46)


When did we start making 'enum' names be in caps? There is an enum 7 lines 
above that is not in all caps.


- Benjamin Hindman


On March 28, 2016, 4:52 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45232/
> ---
> 
> (Updated March 28, 2016, 4:52 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5049
> https://issues.apache.org/jira/browse/MESOS-5049
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some newly created processes such as perf should be killed in case the
> parent dies. Currently this is achieved by forking a new process from the
> child process which serves as a 'watchdog' and kill the child if the parent
> dies. This review introduces this as a general behavior into subprocess
> (and hence removes the need for the custom setup function).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/subprocess.cpp 
> b99bad04f7251169df3bfcec5dee459977440997 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 09e46eb1ce10a6c38cc364077f0b5952579d46e7 
> 
> Diff: https://reviews.apache.org/r/45232/diff/
> 
> 
> Testing
> ---
> 
> Tested complete chain (see https://reviews.apache.org/r/45236/).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, 4:52 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5049
https://issues.apache.org/jira/browse/MESOS-5049


Repository: mesos


Description
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/#review125639
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/subprocess.hpp (line 46)


brace on new line.


- Joris Van Remoortere


On March 28, 2016, 2:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45232/
> ---
> 
> (Updated March 28, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some newly created processes such as perf should be killed in case the
> parent dies. Currently this is achieved by forking a new process from the
> child process which serves as a 'watchdog' and kill the child if the parent
> dies. This review introduces this as a general behavior into subprocess
> (and hence removes the need for the custom setup function).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/subprocess.cpp 
> b99bad04f7251169df3bfcec5dee459977440997 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 09e46eb1ce10a6c38cc364077f0b5952579d46e7 
> 
> Diff: https://reviews.apache.org/r/45232/diff/
> 
> 
> Testing
> ---
> 
> Tested complete chain (see https://reviews.apache.org/r/45236/).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, 2:10 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Introduced subprocess watchdog option [3/7].


Repository: mesos


Description
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Re: Review Request 45232: Introduced subprocess watchdog option.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, 2:09 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Introduced subprocess watchdog option.


Repository: mesos


Description
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Re: Review Request 45232: Introduced subprocess watchdog option [3/7].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, noon)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Introduced subprocess watchdog option [3/7].


Repository: mesos


Description
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Re: Review Request 45232: Introduced subprocess watchdog option.

[Joerg Schad]

> On March 26, 2016, 4:24 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 419-423
> > 
> >
> > I don't think it's obvious from the code that this does a fork, and 
> > that the *parent* will actually exit, and the *child* will continue 
> > execution from this point.
> > Let's make this very clear.

Not sure whether this change is sufficient to what you wanted.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/#review125521
---


On March 28, 2016, 11:57 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45232/
> ---
> 
> (Updated March 28, 2016, 11:57 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some newly created processes such as perf should be killed in case the
> parent dies. Currently this is achieved by forking a new process from the
> child process which serves as a 'watchdog' and kill the child if the parent
> dies. This review introduces this as a general behavior into subprocess
> (and hence removes the need for the custom setup function).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/subprocess.cpp 
> b99bad04f7251169df3bfcec5dee459977440997 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 09e46eb1ce10a6c38cc364077f0b5952579d46e7 
> 
> Diff: https://reviews.apache.org/r/45232/diff/
> 
> 
> Testing
> ---
> 
> Tested complete chain (see https://reviews.apache.org/r/45236/).
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45232: Introduced subprocess watchdog option.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, 11:57 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Adapted comments.


Repository: mesos


Description (updated)
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the parent
dies. This review introduces this as a general behavior into subprocess
(and hence removes the need for the custom setup function).


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Re: Review Request 45232: Introduced subprocess watchdog option.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45232/
---

(Updated March 28, 2016, 11:47 a.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description (updated)
---

Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from the
child process which serves as a 'watchdog' and kill the child if the
parent dies. This review introduces this as a general behavior into
subprocess (and hence removes the need for the custom setup function).


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
09e46eb1ce10a6c38cc364077f0b5952579d46e7 

Diff: https://reviews.apache.org/r/45232/diff/


Testing
---

Tested complete chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad