Re: Review Request 45236: Refactored isolator tests to use parentHook [6/7].

2016-03-28 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45236/
---

(Updated March 28, 2016, 4:53 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5049
https://issues.apache.org/jira/browse/MESOS-5049


Repository: mesos


Description
---

The isolator tests parent process isolates the child while the child
is being blocked. This this the exact patter of a parentHook.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
df506fc793e480e825b476e43c683ef8bcf676b2 

Diff: https://reviews.apache.org/r/45236/diff/


Testing
---

sudo make check on Linux and OSX.


Thanks,

Joerg Schad



Re: Review Request 45236: Refactored isolator tests to use parentHook [6/7].

2016-03-28 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45236/#review125647
---


Ship it!




- Joris Van Remoortere


On March 28, 2016, 1:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45236/
> ---
> 
> (Updated March 28, 2016, 1:38 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The isolator tests parent process isolates the child while the child
> is being blocked. This this the exact patter of a parentHook.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> df506fc793e480e825b476e43c683ef8bcf676b2 
> 
> Diff: https://reviews.apache.org/r/45236/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Linux and OSX.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 45236: Refactored isolator tests to use parentHook [6/7].

2016-03-28 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45236/
---

(Updated March 28, 2016, 1:38 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Refactored isolator tests to use parentHook [6/7].


Repository: mesos


Description
---

The isolator tests parent process isolates the child while the child
is being blocked. This this the exact patter of a parentHook.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
df506fc793e480e825b476e43c683ef8bcf676b2 

Diff: https://reviews.apache.org/r/45236/diff/


Testing
---

sudo make check on Linux and OSX.


Thanks,

Joerg Schad



Re: Review Request 45236: Refactored isolator tests to use parentHook [6/7].

2016-03-28 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45236/
---

(Updated March 28, 2016, 1:09 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed review.


Summary (updated)
-

Refactored isolator tests to use parentHook [6/7].


Repository: mesos


Description (updated)
---

The isolator tests parent process isolates the child while the child
is being blocked. This this the exact patter of a parentHook.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
df506fc793e480e825b476e43c683ef8bcf676b2 

Diff: https://reviews.apache.org/r/45236/diff/


Testing
---

sudo make check on Linux and OSX.


Thanks,

Joerg Schad