Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/#review125612 --- Ship it! Ship It! - Adam B On March 25, 2016, 5:07 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45290/ > --- > > (Updated March 25, 2016, 5:07 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. > > > Repository: mesos > > > Description > --- > > This endpoint previously had no test coverage, so a test was added that hits > the endpoint and checks for the expected output. > > > Diffs > - > > src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e > > Diff: https://reviews.apache.org/r/45290/diff/ > > > Testing > --- > > `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh > --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/#review125495 --- Bad patch! Reviews applied: [44678, 44703, 44515, 44523, 44553, 44554, 45088, 45248, 45249, 45290] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh 2>&1 | tee build_45290"] Error: + : ubuntu:14.04 + : gcc + : --verbose + : GLOG_v=1 MESOS_VERBOSE=1 +++ dirname ./support/docker_build.sh ++ cd ./support/.. ++ pwd + MESOS_DIRECTORY=/home/jenkins/jenkins-slave/workspace/mesos-reviewbot + cd /home/jenkins/jenkins-slave/workspace/mesos-reviewbot + DOCKERFILE=Dockerfile + rm -f Dockerfile + case $OS in + append_dockerfile 'FROM ubuntu:14.04' + echo FROM ubuntu:14.04 + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' + echo RUN rm -rf /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-amd64_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_main_binary-i386_Packages /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release /var/lib/apt/lists/get.docker.io_ubuntu_dists_docker_Release.gpg /var/lib/apt/lists/lock /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_trusty_Release.gpg /var/lib/apt/lists/partial /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_binary-i386_Packages /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_i18n_Translation-en /va r/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_main_source_Sources /var/lib/apt/lists/ppa.launchpad.net_webupd8team_java_ubuntu_dists_trusty_Release /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_InRelease /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_main_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiverse_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_multiver se_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_restricted_source_Sources /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_trusty-security_universe_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-amd64_Packages /var/lib/apt/lists/u s.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_main_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_multiverse_source_Sources /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-backports_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_trusty-b
Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 26, 2016, 12:07 a.m.) Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Changes --- Rebase. Repository: mesos Description --- This endpoint previously had no test coverage, so a test was added that hits the endpoint and checks for the expected output. Diffs (updated) - src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing --- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann
Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/#review125469 --- Patch looks great! Reviews applied: [44678, 44703, 44515, 44523, 44553, 44554, 45088, 45248, 45249, 45290] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 25, 2016, 4:42 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45290/ > --- > > (Updated March 25, 2016, 4:42 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. > > > Repository: mesos > > > Description > --- > > This endpoint previously had no test coverage, so a test was added that hits > the endpoint and checks for the expected output. > > > Diffs > - > > src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e > > Diff: https://reviews.apache.org/r/45290/diff/ > > > Testing > --- > > `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh > --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 25, 2016, 4:42 p.m.) Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Changes --- Rebase. Repository: mesos Description --- This endpoint previously had no test coverage, so a test was added that hits the endpoint and checks for the expected output. Diffs (updated) - src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing --- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann
Re: Review Request 45290: Added a test for the '/files/debug' endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ --- (Updated March 25, 2016, midnight) Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Changes --- Rebase. Repository: mesos Description --- This endpoint previously had no test coverage, so a test was added that hits the endpoint and checks for the expected output. Diffs (updated) - src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing --- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann
