Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-04-04 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review126799 --- Ship it! Ship It! - Daniel Pravat On April 3, 2016, 9:34

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-04-03 Thread Michael Park
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-30 Thread Daniel Pravat
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-30 Thread Michael Park
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-26 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 --- 3rdparty/libprocess/include/process/network.hpp (line 75)

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125387 --- Patch looks great! Reviews applied: [45310, 45311, 45312, 45313,