Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:58 p.m.) Review request for mesos and Ben Mahler. Changes --- Tweak description. Bugs: MESOS-3870 https://issues.apache.org/jira/browse/MESOS-3870 Repository: mesos Description (updated) --- Previously, we returned "Accepted" only for libprocess requests that were issued by non-libprocess clients (that is, client programs that issued requests according to the libprocess protocol but aren't themselves libprocess, such as mesos-go). The reason we didn't return "Accepted" for requests sent by libprocess is that old versions of libprocess (Mesos 0.18 and earlier) wouldn't handle such responses correctly. Since we don't need to maintain compatibility with such ancient versions of libprocess, we can now return "Accepted" responses unconditionally. Note that all recent versions of libprocess will ignore any response that is received to a libprocess request, but that will change in the near future. Diffs (updated) - 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45320/diff/ Testing --- make check Thanks, Neil Conway
Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45320/ --- (Updated March 24, 2016, 9:57 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-3870 https://issues.apache.org/jira/browse/MESOS-3870 Repository: mesos Description --- Previously, we returned "Accepted" only for libprocess requests that were issued by non-libprocess clients (that is, client programs that issued requests according to the libprocess protocol but aren't themselves libprocess, such as mesos-go). The reason we didn't return "Accepted" for requests sent by libprocess is that old versions of libprocess (Mesos 0.18 and earlier) wouldn't handle such responses correctly. Since we don't need to maintain compatibility with such ancient versions of libprocess, we can now return "Accepted" responses unconditionally. Note that all recent versions of libprocess will ignore any response that is received to a libprocess request, but that will change in the near future. Diffs - 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45320/diff/ Testing --- make check Thanks, Neil Conway
