Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu
> On 四月 14, 2016, 10:55 p.m., Jie Yu wrote: > > docs/configuration.md, line 1411 > > > > > > It's a directory or a file? Instead of doing that, can we just assume > > dvdcli is in 'PATH' and add a check in

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review129022 --- docs/configuration.md (line 1411)

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review128941 --- src/slave/flags.cpp (line 803)

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread Guangya Liu
> On 四月 13, 2016, 9:01 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 64 > > > > > > should we verify that the dvdcli binary actually exists here (and if > > not

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 14, 2016, 4:57 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review128743 --- src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line