Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

> On April 9, 2016, 1:02 a.m., Jie Yu wrote:
> > Intead of adding a new flag, I think we should just rely on `--isolation` 
> > flag. For instance, if the operator specify 
> > `--isolation=cgroups/cpu,cgroups/memory`, we will use the cgroup isolator 
> > with cgroups_subsystems: cpu and memory. I think this patch should be the 
> > last patch in the chain so that we can have more thorough testing before 
> > flipping the switch to use the unified cgroup isolator.

@jieyu. I have a question here. If we continue use `--isolation`, does this 
mean we drop supports to exist cgroups isolators(e.g. 
`CgroupsMemIsolatorProcess` and `CgroupsCpushareIsolatorProcess`).


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review127938
---


On April 7, 2016, 10:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 7, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review127938
---



Intead of adding a new flag, I think we should just rely on `--isolation` flag. 
For instance, if the operator specify `--isolation=cgroups/cpu,cgroups/memory`, 
we will use the cgroup isolator with cgroups_subsystems: cpu and memory. I 
think this patch should be the last patch in the chain so that we can have more 
thorough testing before flipping the switch to use the unified cgroup isolator.

- Jie Yu


On April 7, 2016, 10:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 7, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
>   src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated April 7, 2016, 10:40 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin 
Klues, and Neil Conway.


Changes
---

Address @neilc's comment.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
  src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
  src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/#review126858
---




src/slave/flags.cpp (line 335)


Remove the whitespace before "\n".


- Neil Conway


On April 4, 2016, 5:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45350/
> ---
> 
> (Updated April 4, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, 
> Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-5040
> https://issues.apache.org/jira/browse/MESOS-5040
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add `--cgroups_subsystems` in agent flags.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45350/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated April 4, 2016, 5:14 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin 
Klues, and Neil Conway.


Changes
---

Rebase and update reviewers.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md 9ad0c2a201130ac23b22b1a844396dc97ec5ff70 
  src/slave/flags.hpp 9ee7f349cc2bb3fa76141645f4a06fad57664367 
  src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated March 26, 2016, 7:33 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md 9ad0c2a201130ac23b22b1a844396dc97ec5ff70 
  src/slave/flags.hpp 9ee7f349cc2bb3fa76141645f4a06fad57664367 
  src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang