Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-20 Thread haosdent huang
> On June 12, 2016, 1:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 674-677 > > > > > > I see here we call `lambda::bind()`, but in the original `cgroups/mem` >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-20 Thread Qian Zhang
> On June 15, 2016, 4:18 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 505 > > > > > > I can see two issues here: > > 1. `updated` is a field in subsystem level

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-20 Thread Qian Zhang
> On June 12, 2016, 9:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 674-677 > > > > > > I see here we call `lambda::bind()`, but in the original `cgroups/mem` >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-20 Thread haosdent huang
> On June 11, 2016, 2:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 650-656 > > > > > > I see this method is different from the original one: > >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-20 Thread Qian Zhang
> On June 11, 2016, 10:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 650-656 > > > > > > I see this method is different from the original one: > >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 12, 2016, 1:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 674-677 > > > > > > I see here we call `lambda::bind()`, but in the original `cgroups/mem` >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 15, 2016, 8:18 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 505 > > > > > > I can see two issues here: > > 1. `updated` is a field in subsystem level

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 11, 2016, 2:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 650-656 > > > > > > I see this method is different from the original one: > >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated June 19, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137687 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137168 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137119 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 16, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 7, 2016, 10:37 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 4, 2016, 5:21 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-03-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated March 30, 2016, 6:26 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45363: Add `MemorySubsystem ` for cgroups unified isolator.

2016-03-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated March 27, 2016, 4:17 p.m.) Review request for mesos and Jie Yu.