Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review126350 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 7:14 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45367/ > --- > > (Updated March 29, 2016, 7:14 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > --- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/45367/diff/ > > > Testing > --- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review125858 --- Patch looks great! Reviews applied: [44257, 45368, 45367] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 29, 2016, 7:14 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45367/ > --- > > (Updated March 29, 2016, 7:14 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > --- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/45367/diff/ > > > Testing > --- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/45367/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
> On March 28, 2016, 7:13 p.m., James Peach wrote: > > Do you also need to regenerate > > ``3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc``? Oh, I see it is in [r44257](https://reviews.apache.org/r/44257). - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review125716 --- On March 28, 2016, 7:05 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45367/ > --- > > (Updated March 28, 2016, 7:05 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > --- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/45367/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review125716 --- Do you also need to regenerate ``3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc``? - James Peach On March 28, 2016, 7:05 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45367/ > --- > > (Updated March 28, 2016, 7:05 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, > Neil Conway, and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > --- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/45367/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 28, 2016, 6:55 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- Fixed "bugs" and "depends on" fields -- @vinodkone Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/45367/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
