Re: Review Request 45398: Added CHANGELOG for python module changes.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45398/#review125971
---


Ship it!




- Vinod Kone


On March 29, 2016, 2:21 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45398/
> ---
> 
> (Updated March 29, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG for python module changes.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 
> 
> Diff: https://reviews.apache.org/r/45398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 45398: Added CHANGELOG for python module changes.

[Steve Niemitz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45398/
---

(Updated March 29, 2016, 2:21 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Added CHANGELOG for python module changes.


Diffs (updated)
-

  CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 

Diff: https://reviews.apache.org/r/45398/diff/


Testing
---


Thanks,

Steve Niemitz

Re: Review Request 45398: Added CHANGELOG for python module changes.

[Steve Niemitz]

> On March 28, 2016, 9:55 p.m., Vinod Kone wrote:
> > Can you also update the release guide 
> > (https://github.com/apache/mesos/blob/0af8bd6fe28e3cad82d7e05ae3e308c3b2febf29/docs/release-guide.md)
> >  regarding how to upload these new packages to pypi?

As far as I can tell, only mesos.interface is on pypi, the native modules 
aren't.


> On March 28, 2016, 9:55 p.m., Vinod Kone wrote:
> > CHANGELOG, line 26
> > 
> >
> > How about
> > 
> > // This change also removes un-necessary 3rd party dependencies from 
> > `mesos.executor` and `mesos.scheduler`.

 sure


> On March 28, 2016, 9:55 p.m., Vinod Kone wrote:
> > CHANGELOG, line 28
> > 
> >
> > s/modules/modules,/

There shouldn't be a comma there, the way its written is correct.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45398/#review125759
---


On March 28, 2016, 9:13 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45398/
> ---
> 
> (Updated March 28, 2016, 9:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG for python module changes.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 
> 
> Diff: https://reviews.apache.org/r/45398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 45398: Added CHANGELOG for python module changes.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45398/#review125759
---



Can you also update the release guide 
(https://github.com/apache/mesos/blob/0af8bd6fe28e3cad82d7e05ae3e308c3b2febf29/docs/release-guide.md)
 regarding how to upload these new packages to pypi?


CHANGELOG (line 26)


How about

// This change also removes un-necessary 3rd party dependencies from 
`mesos.executor` and `mesos.scheduler`.



CHANGELOG (line 27)


s/man fewer/fewer/

s/.  /. / <- extraneous space here

s/cominding/combining/



CHANGELOG (line 28)


s/modules/modules,/


- Vinod Kone


On March 28, 2016, 9:13 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45398/
> ---
> 
> (Updated March 28, 2016, 9:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CHANGELOG for python module changes.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4c73a2638074ac9f11de1438a5dd3d70e8201229 
> 
> Diff: https://reviews.apache.org/r/45398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>