Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-04-07 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/
---

(Updated April 7, 2016, 5:09 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5071
https://issues.apache.org/jira/browse/MESOS-5071


Repository: mesos


Description
---

All existing clone calls can be specified by providing namespace flags
to subprocess directly.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp 0576eab65a1f3556644472d5c9baba4ea9c34346 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
dde958b252eae75563003ec15087b4231beb285a 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
  src/slave/containerizer/mesos/linux_launcher.cpp 
5028854fa003615f158120e030866b7ec4402b66 
  src/tests/containerizer/launch_tests.cpp 
3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 

Diff: https://reviews.apache.org/r/45495/diff/


Testing
---

sudo make check

../configure --with-network-isolator
make check


Thanks,

Joerg Schad

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-04-05 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/#review127185
---




src/slave/containerizer/mesos/linux_launcher.cpp (line 279)


`SIGCHLD` is not a namespace flag, right?
See my earlier comment about renaming the `namespace` flags.


- Joris Van Remoortere


On March 31, 2016, 10:24 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45495/
> ---
> 
> (Updated March 31, 2016, 10:24 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All existing clone calls can be specified by providing namespace flags
> to subprocess directly.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> dde958b252eae75563003ec15087b4231beb285a 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 5028854fa003615f158120e030866b7ec4402b66 
>   src/tests/containerizer/launch_tests.cpp 
> 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
>   src/tests/containerizer/ns_tests.cpp 
> cd668ebb3b9461bee00dc338c288e5df6eb8fe31 
> 
> Diff: https://reviews.apache.org/r/45495/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> ../configure --with-network-isolator
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-03-31 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/#review126302
---



Patch looks great!

Reviews applied: [45491, 45492, 45493, 45494, 45495]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 10:24 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45495/
> ---
> 
> (Updated March 31, 2016, 10:24 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All existing clone calls can be specified by providing namespace flags
> to subprocess directly.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> dde958b252eae75563003ec15087b4231beb285a 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 5028854fa003615f158120e030866b7ec4402b66 
>   src/tests/containerizer/launch_tests.cpp 
> 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
>   src/tests/containerizer/ns_tests.cpp 
> cd668ebb3b9461bee00dc338c288e5df6eb8fe31 
> 
> Diff: https://reviews.apache.org/r/45495/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> ../configure --with-network-isolator
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-03-31 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/
---

(Updated March 31, 2016, 10:24 a.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5071
https://issues.apache.org/jira/browse/MESOS-5071


Repository: mesos


Description
---

All existing clone calls can be specified by providing namespace flags
to subprocess directly.


Diffs
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
dde958b252eae75563003ec15087b4231beb285a 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
  src/slave/containerizer/mesos/linux_launcher.cpp 
5028854fa003615f158120e030866b7ec4402b66 
  src/tests/containerizer/launch_tests.cpp 
3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 

Diff: https://reviews.apache.org/r/45495/diff/


Testing
---

sudo make check

../configure --with-network-isolator
make check


Thanks,

Joerg Schad