Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-11 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 11, 2016, 7:15 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
---

Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-06 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review127447
---




src/tests/containerizer/fs_tests.cpp (line 35)


Not yours, but we should sort these alphabetically.


- Neil Conway


On April 1, 2016, 5:19 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 1, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> follow haosdent's suggest, remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-01 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126674
---


Ship it!




Ship It!

- haosdent huang


On April 1, 2016, 5:19 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 1, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> follow haosdent's suggest, remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-01 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126560
---



Patch looks great!

Reviews applied: [45500]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 5:19 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 1, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> follow haosdent's suggest, remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-31 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:19 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

follow haosdent's suggest, remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing (updated)
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-31 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:17 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
---

follow haosdent's suggest, remove mesos::internal:: should be enough.


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-31 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:08 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-31 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 1, 2016, 5:07 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

will testing on Linux(ubuntu,centos)


File Attachments (updated)


cgroups.cpp
  
https://reviews.apache.org/media/uploaded/files/2016/04/01/c782c054-1e37-4f92-ae03-55841eca9c05__cgroups.cpp


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-31 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 三月 31, 2016, 10:50 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing (updated)
---

will testing on Linux(ubuntu,centos)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 三月 31, 2016, 3:38 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

make check on localhost(centos)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126233
---




src/linux/fs.hpp 


```
grep -r 'mesos::internal::fs' .
./src/slave/containerizer/mesos/mount.cpp:Try mount = 
mesos::internal::fs::mount(
./src/tests/containerizer/fs_tests.cpp:using 
mesos::internal::fs::MountTable;
./src/tests/containerizer/fs_tests.cpp:using 
mesos::internal::fs::FileSystemTable;
./src/tests/containerizer/fs_tests.cpp:using 
mesos::internal::fs::MountInfoTable;
./src/tests/containerizer/port_mapping_tests.cpp:  
mesos::internal::fs::unmount(target, MNT_DETACH);
```

I think these places need to be updated as well.



src/linux/fs.hpp 


And need remove 
```
// TODO(benh): Move linux/fs.hpp out of 'mesos- namespace.
using namespace mesos::internal;
```
in `linux/fs.cpp` as well.


- haosdent huang


On March 30, 2016, 6:47 p.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated March 30, 2016, 6:47 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> other exists code under src/linux/, e.g. perf.hpp, ns.hpp
> I think remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost(centos)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao


> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote:
> > You must be joking when you say you tested this Linux change on your osx...
> 
> Deshi Xiao wrote:
> Oops. let me testing it again on centos.

Wang Cong, are u a ex-redhatter? if u have alternative linux, please help 
testing with the changes. thanks a lot.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126169
---


On 三月 30, 2016, 6:47 p.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated 三月 30, 2016, 6:47 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> other exists code under src/linux/, e.g. perf.hpp, ns.hpp
> I think remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost(centos)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 三月 30, 2016, 6:44 p.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-

  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 

Diff: https://reviews.apache.org/r/45500/diff/


Testing (updated)
---

make check on localhost(centos)


Thanks,

Deshi Xiao



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao


> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote:
> > You must be joking when you say you tested this Linux change on your osx...

Oops. let me testing it again on centos.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126169
---


On 三月 30, 2016, 6:34 p.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated 三月 30, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> other exists code under src/linux/, e.g. perf.hpp, ns.hpp
> I think remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make check on mac_osx 11
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126169
---



You must be joking when you say you tested this Linux change on your osx...

- Cong Wang


On March 30, 2016, 6:34 p.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated March 30, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> other exists code under src/linux/, e.g. perf.hpp, ns.hpp
> I think remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make check on mac_osx 11
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>