Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread Jay Guo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review130021
---



why not group it into `namespace linux`, along with others in the same 
directory?

- Jay Guo


On April 12, 2016, 11:49 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 12, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> Refers to Benjamin Hindman's TODO:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread haosdent huang


> On April 21, 2016, 5:45 p.m., haosdent huang wrote:
> > src/tests/containerizer/fs_tests.cpp, line 37
> > 
> >
> > I think need remove this blank line.
> 
> Deshi Xiao wrote:
> are u sure? 
> 
> 36 using fs::FileSystemTable; 
> 
>  37   
>   
>  38 namespace mesos {

My bad, I am naping when I write this commment... Let me drop this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review129929
---


On April 12, 2016, 11:49 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 12, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> Refers to Benjamin Hindman's TODO:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread Deshi Xiao


> On 四月 21, 2016, 5:45 p.m., haosdent huang wrote:
> > src/tests/containerizer/fs_tests.cpp, line 37
> > 
> >
> > I think need remove this blank line.

are u sure? 

36 using fs::FileSystemTable;   
  
 37 

 38 namespace mesos {


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review129929
---


On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated 四月 12, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> Refers to Benjamin Hindman's TODO:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-13 Thread Deshi Xiao


> On 四月 6, 2016, 9:04 p.m., Neil Conway wrote:
> > src/tests/containerizer/fs_tests.cpp, line 35
> > 
> >
> > Not yours, but we should sort these alphabetically.

@Neil Conway 

how aobut your feedback.


- Deshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review127447
---


On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated 四月 12, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> Refers to Benjamin Hindman's TODO:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review128396
---



Patch looks great!

Reviews applied: [45500]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 11:49 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 12, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> Refers to Benjamin Hindman's TODO:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 12, 2016, 11:49 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
---

keep fs::mount information should be consolidated and moved to stout,
along with mount and umount.

Refers to Benjamin Hindman's TODO:
https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64


Diffs (updated)
-

  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review128365
---



Bad patch!

Reviews applied: [45500]

Failed command: ./support/apply-review.sh -n -r 45500

Error:
2016-04-12 10:51:36 URL:https://reviews.apache.org/r/45500/diff/raw/ 
[3263/3263] -> "45500.patch" [1]
error: patch failed: src/tests/containerizer/port_mapping_tests.cpp:170
error: src/tests/containerizer/port_mapping_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12479/console

- Mesos ReviewBot


On April 12, 2016, 9:33 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 12, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> This JIRA refers to this TODO from Benjamin Hindman:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 12, 2016, 9:33 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
---

keep fs::mount information should be consolidated and moved to stout,
along with mount and umount.

This JIRA refers to this TODO from Benjamin Hindman:
https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review128096
---



Bad patch!

Reviews applied: [45500]

Failed command: ./support/apply-review.sh -n -r 45500

Error:
2016-04-11 12:16:20 URL:https://reviews.apache.org/r/45500/diff/raw/ 
[3263/3263] -> "45500.patch" [1]
error: patch failed: src/tests/containerizer/port_mapping_tests.cpp:170
error: src/tests/containerizer/port_mapping_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12457/console

- Mesos ReviewBot


On April 11, 2016, 7:23 a.m., Deshi Xiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> ---
> 
> (Updated April 11, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
> https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> keep fs::mount information should be consolidated and moved to stout,
> along with mount and umount.
> 
> This JIRA refers to this TODO from Benjamin Hindman:
> https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/tests/containerizer/fs_tests.cpp 
> 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> ---
> 
> make test on localhost(ubuntu)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>



Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Deshi Xiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
---

(Updated 四月 11, 2016, 7:23 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Summary (updated)
-

Keep fs::mount information should be consolidated.


Bugs: MESOS-1104
https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description (updated)
---

keep fs::mount information should be consolidated and moved to stout,
along with mount and umount.

This JIRA refers to this TODO from Benjamin Hindman:
https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64


Diffs (updated)
-

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45500/diff/


Testing
---

make test on localhost(ubuntu)


Thanks,

Deshi Xiao