Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Jie Yu
> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Cong Wang
> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Jie Yu
> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126372 --- Why /var/run/netns could be in the same mount peer group with its

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126259 --- Patch looks great! Reviews applied: [45520] Passed command: