Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

2016-04-04 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45520/#review126871
---


Ship it!




You don't have to pass the real path to all the places, other places than the 
mount table checking should be fine. But I am totally fine with this patch too.

Please consider to backport this to other releases.

- Cong Wang


On April 4, 2016, 5:29 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45520/
> ---
> 
> (Updated April 4, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Cong Wang.
> 
> 
> Bugs: MESOS-4662
> https://issues.apache.org/jira/browse/MESOS-4662
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used realpath for the bind mount root in port mapping isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> 0fe2f486eb733acf738c1c61fc44f820d7401afc 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
> 
> Diff: https://reviews.apache.org/r/45520/diff/
> 
> 
> Testing
> ---
> 
> sudo make check on Fedora23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

2016-04-04 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45520/
---

(Updated April 4, 2016, 5:29 p.m.)


Review request for mesos, Ian Downes and Cong Wang.


Changes
---

Split the patch per review comments.


Summary (updated)
-

Used realpath for the bind mount root in port mapping isolator.


Bugs: MESOS-4662
https://issues.apache.org/jira/browse/MESOS-4662


Repository: mesos


Description (updated)
---

Used realpath for the bind mount root in port mapping isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
0fe2f486eb733acf738c1c61fc44f820d7401afc 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
323c84a3d960a196d8ba87f753814e9d43a07957 
  src/tests/containerizer/port_mapping_tests.cpp 
e062daa9fcfc776144b48325daa1f1284c5e59a4 

Diff: https://reviews.apache.org/r/45520/diff/


Testing
---

sudo make check on Fedora23


Thanks,

Jie Yu