Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated May 30, 2016, 11:24 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md ae9067d65535ff26e8fd77088748299c91511087 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated May 30, 2016, 11:20 p.m.)


Review request for mesos and Michael Park.


Changes
---

Addressed comment.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md ae9067d65535ff26e8fd77088748299c91511087 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review135557
---


Fix it, then Ship it!





docs/configuration.md (lines 878 - 883)


rename `slave` to `agent` please.


- Vinod Kone


On May 27, 2016, 11:52 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated May 27, 2016, 11:52 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent
> with the `work_dir` located in a subdirectory of `/tmp`. This patch
> adds language to the `work_dir` help strings and configuration docs
> advising users to avoid the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ae9067d65535ff26e8fd77088748299c91511087 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated May 27, 2016, 11:52 a.m.)


Review request for mesos and Michael Park.


Changes
---

Addressed comments.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md ae9067d65535ff26e8fd77088748299c91511087 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review132774
---


Ship it!




Ship It!

- Vinod Kone


On May 7, 2016, 1:29 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated May 7, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent
> with the `work_dir` located in a subdirectory of `/tmp`. This patch
> adds language to the `work_dir` help strings and configuration docs
> advising users to avoid the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review132140
---




docs/configuration.md (line 385)


I'd still opt for including more information: what makes directories that 
are cleaned automatically "unsuitable" for production use?

Should probably be "Example", or spell out the full sentence.



docs/configuration.md (line 872)


I'm confused by what the "as well as" clause means...


- Neil Conway


On May 7, 2016, 1:29 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated May 7, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent
> with the `work_dir` located in a subdirectory of `/tmp`. This patch
> adds language to the `work_dir` help strings and configuration docs
> advising users to avoid the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated May 7, 2016, 1:29 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated April 12, 2016, 5:52 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated April 11, 2016, 9:09 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description (updated)
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

> On March 31, 2016, 10:16 p.m., Joerg Schad wrote:
> > docs/configuration.md, line 354
> > 
> >
> > Not yours but why isn't that flag in the common master/agent section 
> > above?

I decided to put the work_dir flags in the "required flags" section of the 
master/agent (since they're required), rather than the "shared flags" section. 
What do you think?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
---


On April 11, 2016, 4:38 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated April 11, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated April 11, 2016, 4:38 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Summary (updated)
-

Edited `--work_dir` configuration docs.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs (updated)
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann