Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126638 --- Patch looks great! Reviews applied: [45571] Passed command: expo

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126617 --- Ship it! Ship It! - Avinash sridharan On April 1, 2016, 5:36

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > > > > > You had mentioned that if we return an error during `recover` the agent >

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > > > > > You had mentioned that if we return an error during `recover` the agent >

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/ --- (Updated April 1, 2016, 5:36 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 374 > > > > > > s/on/only > > instead of `non-host network(s)` maybe `joined a CNI net

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126592 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > > interf

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 10:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > > inter

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126530 --- Patch looks great! Reviews applied: [45571] Passed command: expo

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 462-467 > > > > > > Is it possible that agent crashes when checkpointing the output of CNI > >

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

> On April 1, 2016, 2:55 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 418-424 > > > > > > I do not think we need this. If agent crashes after removing the > > interf

Re: Review Request 45571: A few cleanups and simplifications in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126511 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line