Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/#review127395
---


Ship it!




Ship It!

- Jie Yu


On April 6, 2016, 5:33 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45596/
> ---
> 
> (Updated April 6, 2016, 5:33 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker containerizer private registry doc.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
> 
> Diff: https://reviews.apache.org/r/45596/diff/
> 
> 
> Testing
> ---
> 
> Tested by buidling with support/site-docker, and verified in web browser.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Gilbert Song 


> On April 2, 2016, 8:20 p.m., Guangya Liu wrote:
> > docs/docker-containerizer.md, line 68
> > 
> >
> > What about 
> > 
> > Rename `.docker/config.json` to `~/.docker/config.json`
> > Rename `.dockercfg` to `~/.dockercfg`
> > 
> > Or clarify that it should be in `HOME` dir, such as s/on each slave/on 
> > each slave `HOME` directory

If we are using the flag pointing to a docker config file, the file is not 
necessary to locate at HOME direcoty.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/#review126711
---


On April 6, 2016, 10:33 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45596/
> ---
> 
> (Updated April 6, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker containerizer private registry doc.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
> 
> Diff: https://reviews.apache.org/r/45596/diff/
> 
> 
> Testing
> ---
> 
> Tested by buidling with support/site-docker, and verified in web browser.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/
---

(Updated April 6, 2016, 10:33 a.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Repository: mesos


Description
---

Updated docker containerizer private registry doc.


Diffs (updated)
-

  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 

Diff: https://reviews.apache.org/r/45596/diff/


Testing (updated)
---

Tested by buidling with support/site-docker, and verified in web browser.


Thanks,

Gilbert Song

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/#review127223
---




docs/docker-containerizer.md (lines 64 - 65)


I won't change this original paragraph.

```
// The original paragraph.

Starting from 0.29, we provide an alternative way to specify docker config 
file for pulling images from private registries. We allow operators to specify 
a shared docker config file using an agent flag. This docker config file will 
be used to pull images from private registries for all containers. See ...
```


- Jie Yu


On April 5, 2016, 7:34 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45596/
> ---
> 
> (Updated April 5, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker containerizer private registry doc.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
> 
> Diff: https://reviews.apache.org/r/45596/diff/
> 
> 
> Testing
> ---
> 
> gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/#review127207
---



Patch looks great!

Reviews applied: [45594, 45595, 45596]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 5, 2016, 7:34 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45596/
> ---
> 
> (Updated April 5, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker containerizer private registry doc.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
> 
> Diff: https://reviews.apache.org/r/45596/diff/
> 
> 
> Testing
> ---
> 
> gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-05 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/
---

(Updated April 5, 2016, 12:34 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Updated docker containerizer private registry doc.


Diffs (updated)
-

  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 

Diff: https://reviews.apache.org/r/45596/diff/


Testing
---

gist


Thanks,

Gilbert Song