Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/ --- (Updated April 5, 2016, 4:45 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

> On April 2, 2016, 7:25 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 817 > > > > > > We should have a comment here explaining why we are not returning a > >

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

> On April 5, 2016, 6:32 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 824 > > > > > > Just wondering if there are any cases that > > `containerNetwork.networkInfo`

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review127047 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126992 --- Patch looks great! Reviews applied: [45620] Passed command:

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

> On April 3, 2016, 3:30 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 95 > > > > > > Can you please clarify why making `networkInfo` as an `Option`? Is > > there any

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126713 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45620: Adjusted the status semantics in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review126699 --- Fix it, then Ship it! Ship It!