Re: Review Request 45621: Added tests for docker spec helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/#review126973
---



Patch looks great!

Reviews applied: [44672, 44673, 44674, 45621]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 6:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45621/
> ---
> 
> (Updated April 4, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for docker spec helpers.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> a0de305553cd21bcf266e902a73138862c348a4f 
> 
> Diff: https://reviews.apache.org/r/45621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45621: Added tests for docker spec helpers.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/
---

(Updated April 4, 2016, 11:49 a.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4939
https://issues.apache.org/jira/browse/MESOS-4939


Repository: mesos


Description
---

Added tests for docker spec helpers.


Diffs (updated)
-

  src/tests/containerizer/docker_spec_tests.cpp 
a0de305553cd21bcf266e902a73138862c348a4f 

Diff: https://reviews.apache.org/r/45621/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 45621: Added tests for docker spec helpers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/#review126839
---


Fix it, then Ship it!





src/tests/containerizer/docker_spec_tests.cpp (line 112)


kill this one. `EXPECT_SOME_EQ` below will check that. Please fix all such 
cases.


- Jie Yu


On April 2, 2016, 8:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45621/
> ---
> 
> (Updated April 2, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for docker spec helpers.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> a0de305553cd21bcf266e902a73138862c348a4f 
> 
> Diff: https://reviews.apache.org/r/45621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 45621: Added tests for docker spec helpers.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45621/#review126705
---




src/tests/containerizer/docker_spec_tests.cpp (line 158)


What about adding `EXPECT_SOME_EQ(80, port);`



src/tests/containerizer/docker_spec_tests.cpp (line 168)


What about adding `EXPECT_SOME_EQ(443, port);`


- Guangya Liu


On 四月 2, 2016, 8:20 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45621/
> ---
> 
> (Updated 四月 2, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4939
> https://issues.apache.org/jira/browse/MESOS-4939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for docker spec helpers.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> a0de305553cd21bcf266e902a73138862c348a4f 
> 
> Diff: https://reviews.apache.org/r/45621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>