Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-18 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 18, 2016, 11:57 a.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-13 Thread Juan Larriba
> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-12 Thread Vinod Kone
> On April 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-09 Thread Juan Larriba
> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127955 --- Bad patch! Reviews applied: [45668] Failed command:

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127944 --- support/docker_build.sh (line 124)

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 8, 2016, 11:26 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 8, 2016, 11:24 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
> On Abr. 8, 2016, 10:55 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 123 > > > > > > Remove the trailing white space and put a period at the end. Also wrap > > at 80 chars. > > > > Also I

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Vinod Kone
> On April 8, 2016, 10:55 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 123 > > > > > > Remove the trailing white space and put a period at the end. Also wrap > > at 80 chars. > > > > Also I

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127912 --- Fix it, then Ship it! support/docker_build.sh (line 122)

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127908 --- Ship it! Ship It! - Vinod Kone On April 8, 2016, 10:41

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 8, 2016, 10:41 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 16 > > > > > > the previous version was working fine on ubuntu and centos. why the > > change? > > Juan Larriba wrote: > It is

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 8, 2016, 10:31 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Vinod Kone
> On April 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 16 > > > > > > the previous version was working fine on ubuntu and centos. why the > > change? > > Juan Larriba wrote: > It is

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 16 > > > > > > the previous version was working fine on ubuntu and centos. why the > > change? It is not working for me on

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127677 --- support/docker_build.sh (line 10)

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-07 Thread Vinod Kone
> On April 7, 2016, 10:13 p.m., Vinod Kone wrote: > > Also can you create an issue on ASF JIRA (if there isn't one already) and attach it to "bugs" in this review? - Vinod --- This is an automatically generated e-mail. To reply,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127398 --- Bad patch! Reviews applied: [45668] Failed command: ['bash',

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-06 Thread Juan Larriba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Abr. 6, 2016, 3:49 p.m.) Review request for mesos, Alex Clemmer,