Re: Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

[Ben Mahler]

> On April 5, 2016, 11:53 p.m., Ben Mahler wrote:
> >

Do we also need the uvm device?


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45715/#review127255
---


On April 4, 2016, 11:41 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45715/
> ---
> 
> (Updated April 4, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5115
> https://issues.apache.org/jira/browse/MESOS-5115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, calls to 'nvidia-smi' would fail inside a container even
> if access to a GPU had been granted. Moreover, access to
> /dev/nvidiactl is actually required for a container to do anything
> useful with a GPU even if it has access to it.
> 
> This patch explicitly grants/revokes access to /dev/nvidiactl as GPUs
> are added and removed from a container in the Nvidia GPU isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
> b0f58035c7c819b42e5f249fadd97312f9e3ac7b 
> 
> Diff: https://reviews.apache.org/r/45715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45715: Added support to grant access to /dev/nvidiactl in Nvidia GPU isolator.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45715/#review127255
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp (lines 
65 - 78)


Could we avoid the static non-POD?


- Ben Mahler


On April 4, 2016, 11:41 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45715/
> ---
> 
> (Updated April 4, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5115
> https://issues.apache.org/jira/browse/MESOS-5115
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, calls to 'nvidia-smi' would fail inside a container even
> if access to a GPU had been granted. Moreover, access to
> /dev/nvidiactl is actually required for a container to do anything
> useful with a GPU even if it has access to it.
> 
> This patch explicitly grants/revokes access to /dev/nvidiactl as GPUs
> are added and removed from a container in the Nvidia GPU isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
> b0f58035c7c819b42e5f249fadd97312f9e3ac7b 
> 
> Diff: https://reviews.apache.org/r/45715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>