Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review128649 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 13, 2016, 1:37 p.m.) Review request for mesos, Avinash

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-12 Thread Qian Zhang
> On April 12, 2016, 6:53 a.m., Jie Yu wrote: > > src/cli/execute.cpp, line 511 > > > > > > You should set DockerInfo network mode as well to 'USER'? Yes, thanks for catching this! - Qian

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review128276 --- src/cli/execute.cpp (line 488)

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127962 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 9, 2016, 10:53 a.m.) Review request for mesos, Avinash

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Avinash sridharan
> On April 5, 2016, 6:25 a.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 152 > > > > > > Should we mention that an image has to be provided && for mesos > > containerizer only? > > Avinash sridharan wrote:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Avinash sridharan
> On April 6, 2016, 12:46 a.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 356 > > > > > > It would much simpler to have a single if conditional here as follows: > > if (networks.isSome()) { > >

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127311 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 6, 2016, 3:56 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
> On April 5, 2016, 2:26 p.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 322 > > > > > > We should support this for `DockerContainerizer` as well, since > > MESOS-4369 is going use the `name` field to

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
> On April 6, 2016, 8:46 a.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 356 > > > > > > It would much simpler to have a single if conditional here as follows: > > if (networks.isSome()) { > >

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127266 --- src/cli/execute.cpp (line 354)

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
> On April 5, 2016, 6:25 a.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 152 > > > > > > Should we mention that an image has to be provided && for mesos > > containerizer only? > > Avinash sridharan wrote:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127079 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 5, 2016, 5:13 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Qian Zhang
> On April 5, 2016, 2:25 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 187 > > > > > > Could you put it below `_dockerImage`? Thanks. Can you please elaborate why we should put it below `_dockerImage`?

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Qian Zhang
> On April 5, 2016, 2:25 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 152 > > > > > > Should we mention that an image has to be provided && for mesos > > containerizer only? > > Avinash sridharan wrote:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127048 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
> On April 5, 2016, 6:25 a.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 152 > > > > > > Should we mention that an image has to be provided && for mesos > > containerizer only? Why do we need an image for

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127044 --- src/cli/execute.cpp (line 322)

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127043 --- src/cli/execute.cpp (line 152)