Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 5:01 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128834 --- Ship it! Ship It! - Kevin Klues On April 14, 2016, 4:23

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
> On 四月 14, 2016, 4:04 a.m., Kevin Klues wrote: > > src/Makefile.am, lines 2137-2141 > > > > > > Assuming this is the right fix, you probably need DESTDIR here too Fixed in the latest patch, is there any way to

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 4:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128829 --- src/Makefile.am (lines 2135 - 2139)

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 3:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
> On April 13, 2016, 11:22 p.m., Vinod Kone wrote: > > Ship It! Don't commit this yet, pert the comment at the botoom of: https://reviews.apache.org/r/46134/ - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128796 --- Ship it! Ship It! - Vinod Kone On April 13, 2016, 2:57

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128714 --- Ship it! Looks great! I've commeted in the JIRA with my final

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
> On 四月 8, 2016, 12:40 a.m., Kevin Klues wrote: > > Thanks for the update! > > > > Doing a quick `git-grep` after applying the patch, I still see a few > > references to `mesos-slave` throughout the code base. Alot of these are in > > the documentation (which I think should be covered by

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 13, 2016, 2:57 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 13, 2016, 2:52 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128460 --- 3rdparty/cmake/Mesos3rdpartyConfigure.cmake (lines 22 - 27)

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 12, 2016, 6:34 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-07 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review127688 --- Thanks for the update! Doing a quick `git-grep` after applying

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-07 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 7, 2016, 7:10 a.m.) Review request for mesos, Kevin Klues and