Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127886 --- Ship it! Ship It! - Ben Mahler On April 8, 2016, 8:34 p.m.,

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/ --- (Updated April 8, 2016, 8:34 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
> On April 8, 2016, 2:24 a.m., haosdent huang wrote: > > Do you forgot to update > > ``` > > diff --git a/src/common/http.cpp b/src/common/http.cpp > > index 3748c71..d2f75b0 100644 > > --- a/src/common/http.cpp > > +++ b/src/common/http.cpp > > @@ -105,6 +105,7 @@ JSON::Object model(const

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127718 --- Do you forgot to update ``` diff --git a/src/common/http.cpp

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127537 --- I suggest to split webui changes from this patch. - haosdent