Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-04-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45944/#review128022
---



Patch looks great!

Reviews applied: [45898, 44090, 45888, 45940, 44081, 44082, 44978, 44084, 
45943, 45944]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45944/
> ---
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
> https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> ecd83c7427353790d93e98ab3d62c46a8da43c96 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-04-09 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45944/#review128008
---


Ship it!




Ship It!

- Michael Park


On April 8, 2016, 8:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45944/
> ---
> 
> (Updated April 8, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4465
> https://issues.apache.org/jira/browse/MESOS-4465
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> ecd83c7427353790d93e98ab3d62c46a8da43c96 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>