Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128809 --- Ship it! Ship It! - Jie Yu On April 14, 2016, midnight,

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? > > Avinash sridharan

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 14, 2016, midnight) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Jie Yu
> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? > > Avinash sridharan

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? If the container does not

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 7:18 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 5:22 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128609 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45956: Added the `_isolate` method.

2016-04-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 4:40 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 12, 2016, 2:13 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-11 Thread Avinash sridharan
> On April 11, 2016, 7:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 762 > > > > > > I don't think 'realpath' is necessary here. Will remove `realpath`. What should

Re: Review Request 45956: Added the `_isolate` method.

2016-04-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128211 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45956: Added the `_isolate` method.

2016-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128015 --- Patch looks great! Reviews applied: [45953, 45954, 45955, 45956]

Re: Review Request 45956: Added the `_isolate` method.

2016-04-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 9, 2016, 5:48 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

2016-04-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review127936 --- Patch looks great! Reviews applied: [45953, 45954, 45955, 45956]