Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-07-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/#review142098 --- Note: I replaced `NULL` with `nullptr` prior to committing. -

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-06-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/ --- (Updated June 2, 2016, 8:30 p.m.) Review request for mesos and Joris Van

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/ --- (Updated May 3, 2016, 9:41 a.m.) Review request for mesos and Joris Van

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-19 Thread Neil Conway
> On April 14, 2016, 7:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 489-490 > > > > > > This is now effectively managed by the `ProcessManager`, so you could > > bring it into the

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-18 Thread Joseph Wu
> On April 14, 2016, 12:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 489-490 > > > > > > This is now effectively managed by the `ProcessManager`, so you could > > bring it into the

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-16 Thread Neil Conway
> On April 14, 2016, 7:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 489-490 > > > > > > This is now effectively managed by the `ProcessManager`, so you could > > bring it into the

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/#review128956 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp