Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-13 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/#review128748
---


Ship it!




Ship It!

- Ben Mahler


On April 12, 2016, 12:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46029/
> ---
> 
> (Updated April 12, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mark a few private functions `static` in libprocess tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> 8a21c6dc9141fe3372f12908a0007dd1c93c5485 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 274a76fa61a5cd4b1324be124f73979d4b980660 
> 
> Diff: https://reviews.apache.org/r/46029/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway 


> On April 11, 2016, 10:44 p.m., Ben Mahler wrote:
> > Mind doing a sweep for this?

I noticed a few more candidates in `futures_test.cpp` and added them to the RR; 
I didn't try to look beyond the libprocess tests.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/#review128274
---


On April 11, 2016, 9:01 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46029/
> ---
> 
> (Updated April 11, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also, remove two unused includes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> e8ee8ee01ee9524b308452c403326e10f75b3ce5 
> 
> Diff: https://reviews.apache.org/r/46029/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/
---

(Updated April 12, 2016, 12:13 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

More `static`s, remove header changes.


Repository: mesos


Description (updated)
---

Mark a few private functions `static` in libprocess tests.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/future_tests.cpp 
8a21c6dc9141fe3372f12908a0007dd1c93c5485 
  3rdparty/libprocess/src/tests/process_tests.cpp 
274a76fa61a5cd4b1324be124f73979d4b980660 

Diff: https://reviews.apache.org/r/46029/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/#review128274
---



Mind doing a sweep for this?


3rdparty/libprocess/src/tests/process_tests.cpp 


Is this a complete header audit? Why only this file? I'd suggest we remove 
this part of the diff.


- Ben Mahler


On April 11, 2016, 9:01 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46029/
> ---
> 
> (Updated April 11, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also, remove two unused includes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> e8ee8ee01ee9524b308452c403326e10f75b3ce5 
> 
> Diff: https://reviews.apache.org/r/46029/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/
---

(Updated April 11, 2016, 9:01 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Tweak, remove unused includes.


Repository: mesos


Description (updated)
---

Also, remove two unused includes.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/process_tests.cpp 
e8ee8ee01ee9524b308452c403326e10f75b3ce5 

Diff: https://reviews.apache.org/r/46029/diff/


Testing (updated)
---

make check


Thanks,

Neil Conway