Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128375 --- Patch looks great! Reviews applied: [45925, 45926, 45927, 46044]

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/ --- (Updated April 12, 2016, 9:59 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-12 Thread Alexander Rukletsov
> On April 11, 2016, 9:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Joseph Wu
> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Jojy Varghese
> On April 11, 2016, 9:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Joseph Wu
> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128265 --- src/cli/execute.cpp

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128246 --- Bad patch! Reviews applied: [46044, 45927, 45926, 45925] Failed