----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46106/#review128538 -----------------------------------------------------------
Patch looks great! Reviews applied: [46106] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 12, 2016, 6:22 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46106/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 6:22 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4171 > https://issues.apache.org/jira/browse/MESOS-4171 > > > Repository: mesos > > > Description > ------- > > Instead of use `Clock::settle()` generally, we change to wait for > scheduler registered exactly before we advance the allocation interval. > > > Diffs > ----- > > src/tests/oversubscription_tests.cpp > 07c66587a136ccd106736abdb6cb8f3f7a651e32 > > Diff: https://reviews.apache.org/r/46106/diff/ > > > Testing > ------- > > Test repeatedly in CentOS 7.1 > > ``` > sudo ./bin/mesos-tests.sh > --gtest_filter="OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover" > --gtest_repeat=200 --gtest_break_on_failure > ``` > > > Thanks, > > haosdent huang > >