Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-15 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/#review129185
---


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 7:05 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46118/
> ---
> 
> (Updated April 15, 2016, 7:05 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4459
> https://issues.apache.org/jira/browse/MESOS-4459
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 31d6c70e7ecb584c75404556508dd9cdcf63fb78 
>   src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
>   src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
>   src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 
> 
> Diff: https://reviews.apache.org/r/46118/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-15 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/
---

(Updated April 15, 2016, 7:05 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added `basic` auth flag.


Bugs: MESOS-4459
https://issues.apache.org/jira/browse/MESOS-4459


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
31d6c70e7ecb584c75404556508dd9cdcf63fb78 
  src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
  src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
  src/tests/scheduler_http_api_tests.cpp 
d469adf7230ce5bb5e71a241a06e389295905e03 
  src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 

Diff: https://reviews.apache.org/r/46118/diff/


Testing
---

make check


Thanks,

Anand Mazumdar



Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/#review128932
---



Patch looks great!

Reviews applied: [46113, 46209, 46114, 46211, 46212, 46115, 46116, 46117, 46118]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 14, 2016, 3:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46118/
> ---
> 
> (Updated April 14, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4459
> https://issues.apache.org/jira/browse/MESOS-4459
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 31d6c70e7ecb584c75404556508dd9cdcf63fb78 
>   src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
>   src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
>   src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 
> 
> Diff: https://reviews.apache.org/r/46118/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-14 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/
---

(Updated April 14, 2016, 3:39 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added the `authenticated_http_frameworks` flag to the tests.


Bugs: MESOS-4459
https://issues.apache.org/jira/browse/MESOS-4459


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
31d6c70e7ecb584c75404556508dd9cdcf63fb78 
  src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
  src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
  src/tests/scheduler_http_api_tests.cpp 
d469adf7230ce5bb5e71a241a06e389295905e03 
  src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 

Diff: https://reviews.apache.org/r/46118/diff/


Testing
---

make check


Thanks,

Anand Mazumdar



Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-13 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/#review128769
---


Ship it!




Ship It!

- Vinod Kone


On April 12, 2016, 10:26 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46118/
> ---
> 
> (Updated April 12, 2016, 10:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4459
> https://issues.apache.org/jira/browse/MESOS-4459
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 31d6c70e7ecb584c75404556508dd9cdcf63fb78 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
>   src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 
> 
> Diff: https://reviews.apache.org/r/46118/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>