Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

[Ben Mahler]

> On April 13, 2016, midnight, Gilbert Song wrote:
> > src/tests/slave_tests.cpp, line 790
> > 
> >
> > use `os::getcwd()` to make consensus with other tests launching 
> > containers.

After thinking about this a bit more, I'm hesitant to use os::getcwd() since it 
makes an implicit assumption about the test being within a sandbox. Ideally the 
cwd comes from the test fixture or environment abstractions to ensure that the 
test is indeed using a temporary directory.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128578
---


On April 12, 2016, 11:15 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46121/
> ---
> 
> (Updated April 12, 2016, 11:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This leads to test failures when multiple invocations are occuring on the 
> machine, or if root ownes /tmp/stdout.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9e9dc35c6f03291648ec451581f762b1ab8b5a8d 
> 
> Diff: https://reviews.apache.org/r/46121/diff/
> 
> 
> Testing
> ---
> 
> make check (previously was failing due to /tmp/stdout being owned by root)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

[Ben Mahler]

> On April 12, 2016, 11:32 p.m., Jie Yu wrote:
> > Not yours, but this test should belong to mesos containerizer test (rather 
> > than slave test). Can you add a TODO?

Will do.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128580
---


On April 12, 2016, 11:15 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46121/
> ---
> 
> (Updated April 12, 2016, 11:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This leads to test failures when multiple invocations are occuring on the 
> machine, or if root ownes /tmp/stdout.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9e9dc35c6f03291648ec451581f762b1ab8b5a8d 
> 
> Diff: https://reviews.apache.org/r/46121/diff/
> 
> 
> Testing
> ---
> 
> make check (previously was failing due to /tmp/stdout being owned by root)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128578
---




src/tests/slave_tests.cpp (line 790)


use `os::getcwd()` to make consensus with other tests launching containers.


- Gilbert Song


On April 12, 2016, 4:15 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46121/
> ---
> 
> (Updated April 12, 2016, 4:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This leads to test failures when multiple invocations are occuring on the 
> machine, or if root ownes /tmp/stdout.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9e9dc35c6f03291648ec451581f762b1ab8b5a8d 
> 
> Diff: https://reviews.apache.org/r/46121/diff/
> 
> 
> Testing
> ---
> 
> make check (previously was failing due to /tmp/stdout being owned by root)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128580
---


Ship it!




Not yours, but this test should belong to mesos containerizer test (rather than 
slave test). Can you add a TODO?

- Jie Yu


On April 12, 2016, 11:15 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46121/
> ---
> 
> (Updated April 12, 2016, 11:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This leads to test failures when multiple invocations are occuring on the 
> machine, or if root ownes /tmp/stdout.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9e9dc35c6f03291648ec451581f762b1ab8b5a8d 
> 
> Diff: https://reviews.apache.org/r/46121/diff/
> 
> 
> Testing
> ---
> 
> make check (previously was failing due to /tmp/stdout being owned by root)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>