Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review167478
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:51 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated Nov. 20, 2016, 4:51 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d 
>   docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce 
> 
> 
> Diff: https://reviews.apache.org/r/46230/diff/3/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-11-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review156418
---



Patch looks great!

Reviews applied: [46227, 52980, 46228, 46229, 46230]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 20, 2016, 4:51 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated Nov. 20, 2016, 4:51 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d 
>   docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce 
> 
> Diff: https://reviews.apache.org/r/46230/diff/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-11-20 Thread Anindya Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/
---

(Updated Nov. 20, 2016, 4:51 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

addressed review comments, and rebased.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

Updated docs to reflect user in persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 410993fb69eb73db6ad17ef361f9b72cba5dc84d 
  docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce 

Diff: https://reviews.apache.org/r/46230/diff/


Testing
---

Documentation change only. All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-11-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review155960
---




docs/persistent-volume.md (lines 101 - 102)


I would include more information here or elsewhere which details the 
permissions we apply to the volumes, including info on the sticky bit if 
present.

Also, it might be worth including the `user` parameter in the example JSON 
below.



docs/persistent-volume.md (line 102)


s/mesos-slave/mesos-agent/


- Greg Mann


On Oct. 18, 2016, 7:46 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated Oct. 18, 2016, 7:46 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
> 
> Diff: https://reviews.apache.org/r/46230/diff/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-10-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review153073
---



Patch looks great!

Reviews applied: [46227, 52980, 46228, 46229, 46230]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 18, 2016, 7:46 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated Oct. 18, 2016, 7:46 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
> 
> Diff: https://reviews.apache.org/r/46230/diff/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-10-18 Thread Anindya Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/
---

(Updated Oct. 18, 2016, 7:46 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

Updated docs to reflect user in persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 

Diff: https://reviews.apache.org/r/46230/diff/


Testing
---

Documentation change only. All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-04-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46230/#review129036
---



Patch looks great!

Reviews applied: [46227, 46228, 46229, 46230]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 14, 2016, 11:04 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46230/
> ---
> 
> (Updated April 14, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to reflect user in persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
> 
> Diff: https://reviews.apache.org/r/46230/diff/
> 
> 
> Testing
> ---
> 
> Documentation change only. All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>