Re: Review Request 46242: Removed a check in Reserve operation validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review133024
---



Patch looks great!

Reviews applied: [46242]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 13, 2016, 12:25 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> ---
> 
> (Updated May 13, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp 
> f014290ed9f279df4c774aeb7ce7bd38fd1cc854 
> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
---

(Updated May 13, 2016, 12:25 a.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212


Repository: mesos


Description
---

When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.


Diffs (updated)
-

  src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/reservation_endpoints_tests.cpp 
f014290ed9f279df4c774aeb7ce7bd38fd1cc854 

Diff: https://reviews.apache.org/r/46242/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review132861
---


Fix it, then Ship it!





src/tests/reservation_endpoints_tests.cpp (line 1442)


Unlike other similar lines you are not using DEFAULT_CREDENTIAL.principal() 
here. Does this mean you want to intentionally use a different one? If so how 
do you ensure this is different? Just "principal" could become the same if 
someone else "creatively" updates DEFAULT_CREDENTIAL.principal later... Maybe 
add some random letters?

On the other hand, I don't think it matters here, so we might as well 
create conformity to avoid confusion and use DEFAULT_CREDENTIAL.principal() 
instead.


- Bernd Mathiske


On April 14, 2016, 11:25 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> ---
> 
> (Updated April 14, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp 
> f014290ed9f279df4c774aeb7ce7bd38fd1cc854 
> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review129082
---



Patch looks great!

Reviews applied: [46242]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 6:25 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> ---
> 
> (Updated April 15, 2016, 6:25 a.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp 
> f014290ed9f279df4c774aeb7ce7bd38fd1cc854 
> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
---

(Updated April 15, 2016, 6:25 a.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212


Repository: mesos


Description
---

When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.


Diffs (updated)
-

  src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/reservation_endpoints_tests.cpp 
f014290ed9f279df4c774aeb7ce7bd38fd1cc854 

Diff: https://reviews.apache.org/r/46242/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review129059
---



Patch looks great!

Reviews applied: [46242]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 1:23 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> ---
> 
> (Updated April 15, 2016, 1:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp 
> f014290ed9f279df4c774aeb7ce7bd38fd1cc854 
> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
---

(Updated April 15, 2016, 1:23 a.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212


Repository: mesos


Description
---

When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.


Diffs
-

  src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/reservation_endpoints_tests.cpp 
f014290ed9f279df4c774aeb7ce7bd38fd1cc854 

Diff: https://reviews.apache.org/r/46242/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann