Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-21 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129996
---



Committed this. But can you send another review for slave/main.cpp as well?

- Vinod Kone


On April 19, 2016, 2:52 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 19, 2016, 2:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, 
> it will auto use process initialize fucntion, 
> as the process::initialize will only call once,
> then in the main fucnton process initialize  
> process::initialize("master") will not be called. 
> So the HTTP request process "delegate" will be wrong, 
> http request will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 7bbc982 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-21 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129994
---


Ship it!




Ship It!

- Vinod Kone


On April 19, 2016, 2:52 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 19, 2016, 2:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, 
> it will auto use process initialize fucntion, 
> as the process::initialize will only call once,
> then in the main fucnton process initialize  
> process::initialize("master") will not be called. 
> So the HTTP request process "delegate" will be wrong, 
> http request will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 7bbc982 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-18 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129478
---



Patch looks great!

Reviews applied: [46249]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 19, 2016, 2:52 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 19, 2016, 2:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, 
> it will auto use process initialize fucntion, 
> as the process::initialize will only call once,
> then in the main fucnton process initialize  
> process::initialize("master") will not be called. 
> So the HTTP request process "delegate" will be wrong, 
> http request will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 7bbc982 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-18 Thread Andy Pang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---

(Updated 四月 19, 2016, 2:52 a.m.)


Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and 
Vinod Kone.


Repository: mesos


Description (updated)
---

If we in hook/module manager use libprocess library, 
it will auto use process initialize fucntion, 
as the process::initialize will only call once,
then in the main fucnton process initialize  
process::initialize("master") will not be called. 
So the HTTP request process "delegate" will be wrong, 
http request will not be response.


Diffs (updated)
-

  src/master/main.cpp 7bbc982 

Diff: https://reviews.apache.org/r/46249/diff/


Testing
---

make check


Thanks,

Andy Pang



Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-18 Thread Vinod Kone


> On April 18, 2016, 3:06 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [46249]
> > 
> > Failed command: ./support/apply-review.sh -n -r 46249
> > 
> > Error:
> > 2016-04-18 03:06:22 URL:https://reviews.apache.org/r/46249/diff/raw/ 
> > [1834/1834] -> "46249.patch" [1]
> > Total errors found: 0
> > Checking 1 files
> > Error: No line in the commit message summary may exceed 72 characters.
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/12581/console

The error here is a bit confusing "no line in the commit message summary..." 
applies to both "Summary"and "Description" of the review. Going forward, please 
remember to line wrap the description at 72 chars also.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129281
---


On April 18, 2016, 5:41 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 18, 2016, 5:41 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, it will auto use process 
> initialize fucntion, as the process::initialize will only call once,then in 
> the main fucnton process initialize  process::initialize("master") will not 
> be called. So the HTTP request process "delegate" will be wrong, http request 
> will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp ea7f0fc 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-17 Thread Andy Pang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---

(Updated 四月 18, 2016, 5:41 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Summary (updated)
-

Hook and module process operation before main process initialize.


Repository: mesos


Description
---

If we in hook/module manager use libprocess library, it will auto use process 
initialize fucntion, as the process::initialize will only call once,then in the 
main fucnton process initialize  process::initialize("master") will not be 
called. So the HTTP request process "delegate" will be wrong, http request will 
not be response.


Diffs
-

  src/master/main.cpp ea7f0fc 

Diff: https://reviews.apache.org/r/46249/diff/


Testing
---

make check


Thanks,

Andy Pang