Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

(Updated April 23, 2016, 4:41 a.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed comments.


Bugs: MESOS-4951
https://issues.apache.org/jira/browse/MESOS-4951


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs (updated)
-

  src/master/main.cpp 7bbc982192b96eed32674070e16575902af80c6d 
  src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-22 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/#review130180
---




src/slave/main.cpp (line 232)


slave->agent?



src/tests/main.cpp (lines 34 - 35)


Alphabetize?



src/tests/main.cpp (line 79)


Why not check the return value here too?


- Kapil Arya


On April 21, 2016, 4:39 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46255/
> ---
> 
> (Updated April 21, 2016, 4:39 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4951
> https://issues.apache.org/jira/browse/MESOS-4951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to enable authentication on libprocess-level
> HTTP endpoints, this patch adds code to the master and
> agent's main.cpp file which makes use of the new
> `authenticationRealm` argument to `process::initialize`
> which allows the authentication realm of such endpoints
> to be set when libprocess is initialized. The argument is
> added to libprocess initialization in the tests as well.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp 7bbc982192b96eed32674070e16575902af80c6d 
>   src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 
>   src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
>   src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 
> 
> Diff: https://reviews.apache.org/r/46255/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-21 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

(Updated April 21, 2016, 8:39 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4951
https://issues.apache.org/jira/browse/MESOS-4951


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs (updated)
-

  src/master/main.cpp 7bbc982192b96eed32674070e16575902af80c6d 
  src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

(Updated April 19, 2016, 4:35 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4951
https://issues.apache.org/jira/browse/MESOS-4951


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs
-

  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

(Updated April 15, 2016, 5:49 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed comment.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs (updated)
-

  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-15 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/#review129093
---


Fix it, then Ship it!





src/tests/mesos.hpp (line 101)


Change to `constexpr char DEFAULT_HTTP_AUTHENTICATION_REALM[] = 
"test-realm"`


- Alexander Rojas


On April 15, 2016, 8:55 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46255/
> ---
> 
> (Updated April 15, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to enable authentication on libprocess-level
> HTTP endpoints, this patch adds code to the master and
> agent's main.cpp file which makes use of the new
> `authenticationRealm` argument to `process::initialize`
> which allows the authentication realm of such endpoints
> to be set when libprocess is initialized. The argument is
> added to libprocess initialization in the tests as well.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
>   src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
> 
> Diff: https://reviews.apache.org/r/46255/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>