Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/ --- (Updated April 25, 2016, 2:20 p.m.) Review request for mesos, Adam B and

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-22 Thread Greg Mann
> On April 22, 2016, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/logging.hpp, lines 28-31 > > > > > > Don't we prefere trailing underscores? For function parameters we use leading

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 --- Fix it, then Ship it! Ship It!