Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/ --- (Updated April 25, 2016, 8:47 p.m.) Review request for mesos, Adam B and

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review130426 --- Ship it! Ship It! - Kapil Arya On April 22, 2016, 3:14

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/ --- (Updated April 22, 2016, 7:14 p.m.) Review request for mesos, Adam B and

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-18 Thread Alexander Rojas
> On April 15, 2016, 1:22 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 551 > > > > > > Can you please add a test where authentication actually works? (for > > saftey) > >

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 11:22 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 551 > > > > > > Can you please add a test where authentication actually works? (for > > saftey) I

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review129098 --- Fix it, then Ship it!