Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130171 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:58 a.m.,

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130062 --- Patch looks great! Reviews applied: [46314] Passed command: expo

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-21 Thread Benjamin Bannier
> On April 18, 2016, 8:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and CMa

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/ --- (Updated April 22, 2016, 7:58 a.m.) Review request for mesos, Zhiwei Chen and V

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-21 Thread Vinod Kone
> On April 18, 2016, 6:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and CMa

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/ --- (Updated April 19, 2016, 4:46 p.m.) Review request for mesos, Zhiwei Chen and V

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review129535 --- Bad patch! Reviews applied: [46314] Failed command: ./support/ap

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
> On April 18, 2016, 8:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and CMa

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
> On April 18, 2016, 8:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and CMa

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/ --- (Updated April 19, 2016, 11:32 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review129384 --- Looks good to me. Is there already a bug reported for this in the

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review129311 --- Patch looks great! Reviews applied: [46314] Passed command: expo