Re: Review Request 46393: Windows: Fixed shell constants, mark `os::shell` as deleted.

2016-05-08 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46393/#review132185
---


Ship it!




Ship It!

- Joris Van Remoortere


On April 23, 2016, 6:56 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46393/
> ---
> 
> (Updated April 23, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3643
> https://issues.apache.org/jira/browse/MESOS-3643
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Windows support for `stout/os/shell.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
> 18f038fa405b45daa5b3b46e4caee0904d7fdd1c 
> 
> Diff: https://reviews.apache.org/r/46393/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46393: Windows: Fixed shell constants, mark `os::shell` as deleted.

2016-04-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46393/
---

(Updated April 23, 2016, 6:56 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Fixed shell constants, mark `os::shell` as deleted.


Bugs: MESOS-3643
https://issues.apache.org/jira/browse/MESOS-3643


Repository: mesos


Description
---

Windows: Added Windows support for `stout/os/shell.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
18f038fa405b45daa5b3b46e4caee0904d7fdd1c 

Diff: https://reviews.apache.org/r/46393/diff/


Testing
---


Thanks,

Alex Clemmer