Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated May 11, 2016, 5 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Alex Clemmer 


> On May 11, 2016, 9:11 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/Makefile.am, line 48
> > 
> >
> > This should be `process/posix/subprocess.hpp`

Huh. I wonder how this happened.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review132625
---


On May 5, 2016, 3:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review132625
---


Fix it, then Ship it!





3rdparty/libprocess/include/Makefile.am (line 48)


This should be `process/posix/subprocess.hpp`



3rdparty/libprocess/include/Makefile.am (line 72)


This should be `process/windows/subprocess.hpp`


- Michael Park


On May 5, 2016, 3:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-09 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review132242
---


Ship it!




Ship It!

- Michael Park


On May 5, 2016, 3:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated May 5, 2016, 3:35 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer 


> On April 27, 2016, 8:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 13-42
> > 
> >
> > It seems like most of these are no longer necessary. Can we prune this 
> > a little bit, please?

Update: In the new changeset, these are mostly used now.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review130841
---


On May 3, 2016, 5:44 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 3, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer 


> On April 27, 2016, 8:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 44-46
> > 
> >
> > Doesn't look like we need these anymore.

Update: We do need them in the new changeset.


> On April 27, 2016, 8:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 61-76
> > 
> >
> > There's a copy of this in `src/subprocess_posix.cpp`. It seems like 
> > this was supposed to be removed?

In the new changeset we have merged all these implementations.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review130841
---


On May 3, 2016, 5:44 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 3, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-02 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated May 3, 2016, 5:44 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-04-27 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review130841
---




3rdparty/libprocess/src/subprocess.cpp (lines 13 - 42)


It seems like most of these are no longer necessary. Can we prune this a 
little bit, please?



3rdparty/libprocess/src/subprocess.cpp (lines 44 - 46)


Doesn't look like we need these anymore.



3rdparty/libprocess/src/subprocess.cpp 


Why didn't this comment make it over to `src/subprocess_posix.cpp`?



3rdparty/libprocess/src/subprocess.cpp (lines 56 - 71)


There's a copy of this in `src/subprocess_posix.cpp`. It seems like this 
was supposed to be removed?



3rdparty/libprocess/src/subprocess_windows.cpp (line 36)


This isn't used.


- Michael Park


On April 23, 2016, 11:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated April 23, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-04-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated April 23, 2016, 11:40 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Forked `subprocess.cpp`.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer