Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-23 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/#review134446
---


Ship it!




Ship It!

- Jie Yu


On May 12, 2016, 8:13 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46436/
> ---
> 
> (Updated May 12, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_FailedPlugin".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46436/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
> [   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-12 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/
---

(Updated May 12, 2016, 4:13 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_FailedPlugin".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46436/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
[   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)


Thanks,

Qian Zhang

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-06 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/
---

(Updated May 6, 2016, 10:08 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_FailedPlugin".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46436/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
[   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)


Thanks,

Qian Zhang

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-05 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/
---

(Updated May 5, 2016, 10:56 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_FailedPlugin".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46436/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
[   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)


Thanks,

Qian Zhang

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-04-21 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/#review129991
---


Fix it, then Ship it!




Ship It!


src/tests/containerizer/cni_isolator_tests.cpp (line 307)


s/cause the task failed/will not allow a task to be launched.


- Avinash sridharan


On April 20, 2016, 2:40 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46436/
> ---
> 
> (Updated April 20, 2016, 2:40 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_FailedPlugin".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46436/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
> [   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>