Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/
---

(Updated April 22, 2016, 4:40 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

In this changes, we update the `high-availability` and
`operational-guide` documents about master http endpoints redirction
when current master is not the leader.


Diffs (updated)
-

  docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
  docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 

Diff: https://reviews.apache.org/r/46473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review130113
---


Ship it!




Ship It!

- Neil Conway


On April 22, 2016, 4:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 22, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/
---

(Updated April 22, 2016, 4:10 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Address @neilc's comments.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

In this changes, we update the `high-availability` and
`operational-guide` documents about master http endpoints redirction
when current master is not the leader.


Diffs (updated)
-

  docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
  docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 

Diff: https://reviews.apache.org/r/46473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review130101
---




docs/high-availability.md (line 29)


Can we link to the endpoint docs for `/redirect` here? i.e., 
[/redirect](endpoint/master/redirect.md)



docs/high-availability.md (line 30)


"For HTTP endpoints that only work at the leading master, requests made to 
endpoints at a non-leading master will result in an HTTP 307 redirect to the 
current leading master."



docs/operational-guide.md (line 69)


Can we link to the endpoint docs for `/state` and `/metrics/snapshot`?


- Neil Conway


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review130070
---



Patch looks great!

Reviews applied: [34646, 46471, 46472, 46473]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/
---

(Updated April 22, 2016, 7:18 a.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Fix style error and rebase.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

In this changes, we update the `high-availability` and
`operational-guide` documents about master http endpoints redirction
when current master is not the leader.


Diffs (updated)
-

  docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
  docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 

Diff: https://reviews.apache.org/r/46473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review130037
---



Bad patch!

Reviews applied: [46473, 46472, 46471, 34646]

Failed command: ./support/apply-review.sh -n -r 46471

Error:
2016-04-22 05:54:52 URL:https://reviews.apache.org/r/46471/diff/raw/ 
[12860/12860] -> "46471.patch" [1]
src/master/http.cpp:1310:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 1
Checking 1 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12664/console

- Mesos ReviewBot


On April 22, 2016, 4:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 22, 2016, 4:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-21 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review130008
---




docs/high-availability.md (line 29)


Rephrase

"In addition to ZooKeeper, one can get the location of the leading master 
by sending an HTTP request to `/redirect` endpoint on any master."

Kill the second line.



docs/operational-guide.md (line 68)


## HTTP requests to non-leading master

HTTP requests to some master endpoints (e.g., /state, /metrics/snapshot) 
can only be answered by the leading master. Such requests made to a non-leading 
master will result in either a `307 Temporary Redirect` (with the location of 
the leading master) or `503 Service Unavailable` (if the master does not know 
who the current leader is).


- Vinod Kone


On April 21, 2016, 4:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 21, 2016, 4:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46473/#review129861
---



Patch looks great!

Reviews applied: [34646, 46471, 46472, 46473]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 21, 2016, 4:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46473/
> ---
> 
> (Updated April 21, 2016, 4:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we update the `high-availability` and
> `operational-guide` documents about master http endpoints redirction
> when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   docs/high-availability.md b0e744e62081b56e2a24ef5f7304f424424fa3cc 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>