Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-06-20 Thread Alexander Rojas
> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote: > > docs/authorization.md, lines 125-136 > > > > > > According to > > https://mesos.apache.org/documentation/latest/markdown-style-guide/ , we > > should

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-19 Thread Alexander Rukletsov
> On May 18, 2016, 10:17 a.m., Alexander Rukletsov wrote: > > docs/authorization.md, lines 566-580 > > > > > > It's hard to remember that this doc should be updated if changes to the > > proto are made. Can we

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-19 Thread Alexander Rojas
> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote: > > docs/authorization.md, lines 566-580 > > > > > > It's hard to remember that this doc should be updated if changes to the > > proto are made. Can we

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133711 --- Fix it, then Ship it! I've wrapped the text and did a final

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133620 --- Please wrap paragraphs at 80 chars. - Alexander Rukletsov On

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133607 --- Fix it, then Ship it! Hey Alexander, the text looks great to

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133532 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated May 17, 2016, 3:11 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133511 --- Fix it, then Ship it! docs/authorization.md (line 478)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated May 12, 2016, 11:22 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-12 Thread Alexander Rojas
> On May 10, 2016, 8:36 p.m., Greg Mann wrote: > > docs/authorization.md, line 66 > > > > > > I find it a bit confusing that we explain the `permissive` field first > > here, when the other fields are really the

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132501 --- docs/authorization.md (line 10)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132271 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated May 9, 2016, 12:49 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132236 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132234 --- docs/authorization.md (line 12)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated May 9, 2016, 10:49 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-09 Thread Alexander Rojas
> On April 29, 2016, 4:07 p.m., Neil Conway wrote: > > docs/authorization.md, line 276 > > > > > > For consistency, this needs a newline (``). using table instead. - Alexander

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132138 --- docs/authorization.md (line 8)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review131092 --- docs/authorization.md (line 8)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated April 28, 2016, 11:56 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130644 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated April 26, 2016, 5:14 p.m.) Review request for mesos, Adam B, Greg

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130540 --- docs/authorization.md (line 12)

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130097 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130080 --- docs/authorization.md

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review129933 --- Patch looks great! Reviews applied: [46501] Passed command: