Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

2016-05-11 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46533/#review132718
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46533/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead, we now use top-level configure script directly to generate
> libprocess/stout Makefiles.  As a result, all configure flags are
> handled at one place to generate appropriate Makefiles.
> 
> With this approach, we need to explicitly ask libprocess Makefile to
> generate a static library instead of a shared one. Previously, this
> was done via libprocess' configure script.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46533/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>



Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

2016-05-10 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46533/
---

(Updated May 10, 2016, 5:49 p.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

Instead, we now use top-level configure script directly to generate
libprocess/stout Makefiles.  As a result, all configure flags are
handled at one place to generate appropriate Makefiles.

With this approach, we need to explicitly ask libprocess Makefile to
generate a static library instead of a shared one. Previously, this
was done via libprocess' configure script.


Diffs (updated)
-

  3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
  configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 

Diff: https://reviews.apache.org/r/46533/diff/


Testing
---


Thanks,

Kapil Arya



Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

2016-04-21 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46533/
---

(Updated April 21, 2016, 6:53 p.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

Instead, we now use top-level configure script directly to generate
libprocess/stout Makefiles.  As a result, all configure flags are
handled at one place to generate appropriate Makefiles.

With this approach, we need to explicitly ask libprocess Makefile to
generate a static library instead of a shared one. Previously, this
was done via libprocess' configure script.


Diffs
-

  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 

Diff: https://reviews.apache.org/r/46533/diff/


Testing
---


Thanks,

Kapil Arya



Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

2016-04-21 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46533/
---

(Updated April 21, 2016, 6:02 p.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5247
https://issues.apache.org/jira/browse/MESOS-5247


Repository: mesos


Description
---

Instead, we now use top-level configure script directly to generate
libprocess/stout Makefiles.  As a result, all configure flags are
handled at one place to generate appropriate Makefiles.

With this approach, we need to explicitly ask libprocess Makefile to
generate a static library instead of a shared one. Previously, this
was done via libprocess' configure script.


Diffs
-

  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 

Diff: https://reviews.apache.org/r/46533/diff/


Testing
---


Thanks,

Kapil Arya