Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review132725
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

> On May 4, 2016, 11:33 a.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?
> 
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either 
> :-(. I believe there might be a way to figure it out but I am not so sure 
> given that we are talking about 3rdparty software (with their own configure 
> scripts) here. I'll try to think of a better alternative.
> 
> James Peach wrote:
> Another question ... I don't recall whether you actually need the link 
> flags for modules? all the 3rdparty libraries should already be present in 
> the mesos process by the time module are loaded, so you wouldn't need them at 
> link time. Right?

If someone wants to generate a binary file, say as a helper process for the 
module, they'll need the libraries.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 10, 2016, 5:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 10, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review132561
---



Bad patch!

Reviews applied: [46540, 46538, 46537, 46539, 46536, 46535, 46534, 46533, 
46532, 46531, 46530, 46529, 46528, 46527, 46526, 46525, 46524, 46523, 46522, 
46521, 46520, 46519, 46518, 46517, 46516, 46515, 46514]

Failed command: ./support/apply-review.sh -n -r 46525

Error:
2016-05-10 22:52:03 URL:https://reviews.apache.org/r/46525/diff/raw/ 
[23564/23564] -> "46525.patch" [1]
3rdparty/glog-0.3.3.patch:21: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:31: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:41: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:43: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:54: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:59: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:68: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:77: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:85: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:91: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:95: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:104: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:113: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:160: space before tab in indent.
+   echo powerpc64-unknown-linux-gnu
3rdparty/glog-0.3.3.patch:161: space before tab in indent.
+   exit ;;
3rdparty/glog-0.3.3.patch:166: space before tab in indent.
+   case `sed -n '/^cpu model/s/^.*: \(.*\)/\1/p' < /proc/cpuinfo` in
3rdparty/glog-0.3.3.patch:167: space before tab in indent.
+ EV5)   UNAME_MACHINE=alphaev5 ;;
3rdparty/glog-0.3.3.patch:175: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:200: trailing whitespace.
+ 

Full log: https://builds.apache.org/job/mesos-reviewbot/12992/console

- Mesos ReviewBot


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/
---

(Updated May 10, 2016, 5:50 p.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

Updated pkg-config file to include module dependency info.


Diffs (updated)
-

  configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
  mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 

Diff: https://reviews.apache.org/r/46540/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[James Peach]

> On May 4, 2016, 3:33 p.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?
> 
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either 
> :-(. I believe there might be a way to figure it out but I am not so sure 
> given that we are talking about 3rdparty software (with their own configure 
> scripts) here. I'll try to think of a better alternative.

Another question ... I don't recall whether you actually need the link flags 
for modules? all the 3rdparty libraries should already be present in the mesos 
process by the time module are loaded, so you wouldn't need them at link time. 
Right?


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 4, 2016, 3:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

> On May 4, 2016, 11:33 a.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?

On 32-bit, they'll be installed in lib. On 64-bit, it could be either :-(. I 
believe there might be a way to figure it out but I am not so sure given that 
we are talking about 3rdparty software (with their own configure scripts) here. 
I'll try to think of a better alternative.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 4, 2016, 11:22 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 11:22 a.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---




configure.ac (line 591)


So in practice, libraries would be installed in either ``3rdparty/lib64`` 
or ``3rdparty/lib``, but not both?

Is there a libtool or autoconf variable to figure that out?


- James Peach


On May 4, 2016, 3:22 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 4, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/
---

(Updated May 4, 2016, 11:22 a.m.)


Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy 
St. Clair.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

Updated pkg-config file to include module dependency info.


Diffs
-

  configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
  mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 

Diff: https://reviews.apache.org/r/46540/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review129972
---



Bad patch!

Reviews applied: [46540, 46539, 46536, 46535, 46534, 46533, 46532, 46531, 
46530, 46529, 46528, 46527, 46526, 46525, 46524, 46523, 46522, 46521, 46520, 
46519, 46518, 46517, 46516, 46515, 46514]

Failed command: ./support/apply-review.sh -n -r 46525

Error:
2016-04-21 22:19:06 URL:https://reviews.apache.org/r/46525/diff/raw/ 
[22698/22698] -> "46525.patch" [1]
3rdparty/glog-0.3.3.patch:21: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:31: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:41: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:43: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:54: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:59: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:68: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:77: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:85: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:91: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:95: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:104: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:113: trailing whitespace.
+ 
3rdparty/glog-0.3.3.patch:160: space before tab in indent.
+   echo powerpc64-unknown-linux-gnu
3rdparty/glog-0.3.3.patch:161: space before tab in indent.
+   exit ;;
3rdparty/glog-0.3.3.patch:166: space before tab in indent.
+   case `sed -n '/^cpu model/s/^.*: \(.*\)/\1/p' < /proc/cpuinfo` in
3rdparty/glog-0.3.3.patch:167: space before tab in indent.
+ EV5)   UNAME_MACHINE=alphaev5 ;;

Full log: https://builds.apache.org/job/mesos-reviewbot/12658/console

- Mesos ReviewBot


On April 21, 2016, 10:02 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-4434
> https://issues.apache.org/jira/browse/MESOS-4434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>