Re: Review Request 46621: Added alias support for flags.

> On May 5, 2016, 10:12 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 828-830 > > > > > > ```cpp > >auto iter = aliases.count(flag_name) ? > >

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated May 12, 2016, 1:36 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

> On April 30, 2016, 6:29 a.m., Greg Mann wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 841 > > > > > > Why the raw pointer here? as opposed to keeping it a const ref? because i

Re: Review Request 46621: Added alias support for flags.

> On May 5, 2016, 10:12 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 828-830 > > > > > > ```cpp > >auto iter = aliases.count(flag_name) ? > >

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131951 --- Fix it, then Ship it!

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131245 --- Fix it, then Ship it!

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 30, 2016, 3:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131240 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 30, 2016, 2 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 29, 2016, 3:26 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review130685 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 26, 2016, 1:04 a.m.) Review request for mesos and Ben Mahler.